Run the "Relaunch Chrome" dialog test everywhere.

Run the "Relaunch Chrome" dialog test everywhere.

For Linux, this requires an update to WidgetTest::GetAllWidgets() (added
in r447216) in order to include Widgets created with a parent
aura::Window that is a DesktopWindowTreeHost's root rather than the
host's content window.

BUG=684167, 683808
Review-Url: https://codereview.chromium.org/2663163004
Cr-Commit-Position: refs/heads/master@{#448452}
Committed: https://chromium.googlesource.com/chromium/src/+/f0c12ecaa44ccc4511ea33c1705dec4caa972304

[tapted, 2017-02-01 00:29:21]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 00:30:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 01:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 01:23:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2017-02-02 02:02:39]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 02:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 04:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 04:57:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2017-02-06 05:22:41]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 05:23:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-02-06 06:01:17]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 06:02:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 06:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 06:15:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2017-02-06 06:32:09]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 06:32:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-02-06 06:42:45]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 06:42:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 07:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 07:46:57]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-02-06 11:27:27]

Patchset #5 (id:80001) has been deleted

[tapted, 2017-02-06 11:31:03]

Description was changed from

==========
Run the "Relaunch Chrome" dialog test everywhere.

The testing framework fix for http://crbug.com/683808 in r447216 should
make this test reliable on all platforms.

BUG=684167, 683808
==========

to

==========
Run the "Relaunch Chrome" dialog test everywhere.

This requires an update to WidgetTest::GetAllWidgets() (added in
r447216) in order to include Widgets created with a parent aura::Window
that is a DesktopWindowTreeHost's root rather than the host's content
window.

BUG=684167, 683808
==========

[tapted, 2017-02-06 11:31:03]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2017-02-06 11:32:14]

Description was changed from

==========
Run the "Relaunch Chrome" dialog test everywhere.

This requires an update to WidgetTest::GetAllWidgets() (added in
r447216) in order to include Widgets created with a parent aura::Window
that is a DesktopWindowTreeHost's root rather than the host's content
window.

BUG=684167, 683808
==========

to

==========
Run the "Relaunch Chrome" dialog test everywhere.

For Linux, this requires an update to WidgetTest::GetAllWidgets() (added
in r447216) in order to include Widgets created with a parent
aura::Window that is a DesktopWindowTreeHost's root rather than the
host's content window.

BUG=684167, 683808
==========

[tapted, 2017-02-06 11:34:23]

Hi sky, please take a look. I think this makes sense to ensure the behaviour of
GetAllWidgets() is consistent across platforms, but I'll poke at the creation
codepaths some more too to see if there's anything weird going on.

(and I'll ping you when I update the TestBrowserDialog doc - ran out of time
today after sheriffing)

Thanks!

[sky, 2017-02-06 17:29:47]

https://codereview.chromium.org/2663163004/diff/100001/ui/views/test/widget_t...
File ui/views/test/widget_test_aura.cc (right):

https://codereview.chromium.org/2663163004/diff/100001/ui/views/test/widget_t...
ui/views/test/widget_test_aura.cc:166: std::vector<aura::Window*> toplevels =
GetAllTopLeveLWindows();
optional: don't bother with local, change for to:
for (aura::Window* window : GetAllTopLevelWindows().

https://codereview.chromium.org/2663163004/diff/100001/ui/views/test/widget_t...
ui/views/test/widget_test_aura.cc:166: std::vector<aura::Window*> toplevels =
GetAllTopLeveLWindows();
How about fixing the capitalization here, e.g. "LeveL" -> "Level"

[sky, 2017-02-06 17:29:52]

LGTM

[tapted, 2017-02-06 22:49:09]

Patchset #6 (id:120001) has been deleted

[tapted, 2017-02-06 22:50:49]

https://codereview.chromium.org/2663163004/diff/100001/ui/views/test/widget_t...
File ui/views/test/widget_test_aura.cc (right):

https://codereview.chromium.org/2663163004/diff/100001/ui/views/test/widget_t...
ui/views/test/widget_test_aura.cc:166: std::vector<aura::Window*> toplevels =
GetAllTopLeveLWindows();
On 2017/02/06 17:29:47, sky wrote:
> optional: don't bother with local, change for to:
> for (aura::Window* window : GetAllTopLevelWindows().

Done.

https://codereview.chromium.org/2663163004/diff/100001/ui/views/test/widget_t...
ui/views/test/widget_test_aura.cc:166: std::vector<aura::Window*> toplevels =
GetAllTopLeveLWindows();
On 2017/02/06 17:29:47, sky wrote:
> How about fixing the capitalization here, e.g. "LeveL" -> "Level"

Ach - thanks. Done.

[tapted, 2017-02-06 22:50:56]

The CQ bit was checked by tapted@chromium.org

[tapted, 2017-02-06 22:50:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2663163004/#ps130001
(title: "respond to comments")

[commit-bot: I haz the power, 2017-02-06 22:51:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 00:04:56]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1486421456236140,
"parent_rev": "205490f5a8f85cb70535d3b67b3cbc76206953e1", "commit_rev":
"f0c12ecaa44ccc4511ea33c1705dec4caa972304"}

[commit-bot: I haz the power, 2017-02-07 00:05:25]

Description was changed from

==========
Run the "Relaunch Chrome" dialog test everywhere.

For Linux, this requires an update to WidgetTest::GetAllWidgets() (added
in r447216) in order to include Widgets created with a parent
aura::Window that is a DesktopWindowTreeHost's root rather than the
host's content window.

BUG=684167, 683808
==========

to

==========
Run the "Relaunch Chrome" dialog test everywhere.

For Linux, this requires an update to WidgetTest::GetAllWidgets() (added
in r447216) in order to include Widgets created with a parent
aura::Window that is a DesktopWindowTreeHost's root rather than the
host's content window.

BUG=684167, 683808

Review-Url: https://codereview.chromium.org/2663163004
Cr-Commit-Position: refs/heads/master@{#448452}
Committed:
https://chromium.googlesource.com/chromium/src/+/f0c12ecaa44ccc4511ea33c1705d...
==========

[commit-bot: I haz the power, 2017-02-07 00:05:26]

Committed patchset #6 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/f0c12ecaa44ccc4511ea33c1705d...