Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2663143002: Add FacingMode to the values returned from MediaStreamTrack.getSettings. (Closed)

Created:
3 years, 10 months ago by wuchengli
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Add FacingMode to the values returned from MediaStreamTrack.getSettings. Spec link: https://w3c.github.io/mediacapture-main/getusermedia.html#dom-mediatracksettings-facingmode Note on testing: Testing this properly at the JS API level requires the ability to insert fake devices with properties set by the test. That's too much for this CL. Once https://codereview.chromium.org/2609863004/ lands, this can be manually tested on Chromebooks. BUG=617142 Review-Url: https://codereview.chromium.org/2590193002 Cr-Commit-Position: refs/heads/master@{#445022} (cherry picked from commit 2d50a1b3b003d4a51a8f2ff4153d29a0273586eb) Review-Url: https://codereview.chromium.org/2663143002 . Cr-Commit-Position: refs/branch-heads/2987@{#211} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/786385548e85c79e9cbbeac3ac79d1837a49e326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M content/renderer/media/media_stream_video_track.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamTrack.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wuchengli
3 years, 10 months ago (2017-01-31 02:56:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
786385548e85c79e9cbbeac3ac79d1837a49e326.

Powered by Google App Engine
This is Rietveld 408576698