Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2663073004: Temporarily disable two-finger spoken feedback toggle. (Closed)

Created:
3 years, 10 months ago by dmazzoni
Modified:
3 years, 10 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable two-finger spoken feedback toggle. We want to disable it in M57 and then improve the UI in M58. BUG=687293 Review-Url: https://codereview.chromium.org/2663073004 Cr-Commit-Position: refs/heads/master@{#447358} Committed: https://chromium.googlesource.com/chromium/src/+/200099cd3405192d97a6a85e63adee63d343f89e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 2 chunks +6 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (8 generated)
dmazzoni
3 years, 10 months ago (2017-01-31 20:49:17 UTC) #2
David Tseng
https://codereview.chromium.org/2663073004/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/2663073004/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode569 chrome/browser/chromeos/accessibility/accessibility_manager.cc:569: #else Why not just remove this block?
3 years, 10 months ago (2017-01-31 20:55:31 UTC) #5
dmazzoni
https://codereview.chromium.org/2663073004/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/2663073004/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode569 chrome/browser/chromeos/accessibility/accessibility_manager.cc:569: #else On 2017/01/31 20:55:31, David Tseng wrote: > Why ...
3 years, 10 months ago (2017-01-31 21:02:30 UTC) #6
David Tseng
lgtm
3 years, 10 months ago (2017-01-31 23:04:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663073004/1
3 years, 10 months ago (2017-01-31 23:13:55 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 23:22:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/200099cd3405192d97a6a85e63ad...

Powered by Google App Engine
This is Rietveld 408576698