Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: appengine/findit/model/crash/test/chrome_crash_analysis_test.py

Issue 2663063007: [Predator] Switch from anonymous dict to CrashData. (Closed)
Patch Set: Rebase and fix delta test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/crash/test/chrome_crash_analysis_test.py
diff --git a/appengine/findit/model/crash/test/chrome_crash_analysis_test.py b/appengine/findit/model/crash/test/chrome_crash_analysis_test.py
index 7d0982977a8439c93265936f0bdec84695fac9d4..70d80d81fee94f2e393469a2f580445fcf3a6fd0 100644
--- a/appengine/findit/model/crash/test/chrome_crash_analysis_test.py
+++ b/appengine/findit/model/crash/test/chrome_crash_analysis_test.py
@@ -4,6 +4,7 @@
from datetime import datetime
+from crash.chrome_crash_data import ChromeCrashData
from crash.test.predator_testcase import PredatorTestCase
from model import analysis_status
from model import result_status
@@ -34,12 +35,39 @@ class ChromeCrashAnalysisTest(PredatorTestCase):
self.assertIsNone(analysis.channel)
self.assertIsNone(analysis.historical_metadata)
- def testChromeCrashAnalysisCustomizedProperty(self):
+ def testInitializeWithCrashData(self):
+ findit = self.GetMockFindit()
+ channel = 'dummy channel'
+ historical_metadata = []
+ crash_data = self.GetDummyChromeCrashData(
+ channel=channel, historical_metadata=historical_metadata)
+ class MockChromeCrashData(ChromeCrashData):
+
+ def __init__(self, crash_data):
+ super(MockChromeCrashData, self).__init__(crash_data, None)
+
+ @property
+ def stacktrace(self):
+ return None
+
+ @property
+ def regression_range(self):
+ return None
+
+ @property
+ def dependencies(self):
+ return {}
+
+ @property
+ def dependency_rolls(self):
+ return {}
+
+ self.mock(findit, 'GetCrashData',
+ lambda crash_data: MockChromeCrashData( # pylint: disable=W0108
+ crash_data))
+
+ crash_data = findit.GetCrashData(crash_data)
analysis = ChromeCrashAnalysis()
- analysis.historical_metadata = {'chrome_version': '50.0.1200.0',
- 'cpm': 0.5}
- analysis.channel = 'canary'
- self.assertEqual(analysis.customized_data,
- {'historical_metadata': {'chrome_version': '50.0.1200.0',
- 'cpm': 0.5},
- 'channel': 'canary'})
+ analysis.Initialize(crash_data)
+ self.assertEqual(analysis.channel, channel)
+ self.assertEqual(analysis.historical_metadata, historical_metadata)
« no previous file with comments | « appengine/findit/model/crash/crash_analysis.py ('k') | appengine/findit/model/crash/test/crash_analysis_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698