Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: appengine/findit/model/crash/test/chrome_crash_analysis_test.py

Issue 2663063007: [Predator] Switch from anonymous dict to CrashData. (Closed)
Patch Set: Rebase and fix delta test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from datetime import datetime 5 from datetime import datetime
6 6
7 from crash.chrome_crash_data import ChromeCrashData
7 from crash.test.predator_testcase import PredatorTestCase 8 from crash.test.predator_testcase import PredatorTestCase
8 from model import analysis_status 9 from model import analysis_status
9 from model import result_status 10 from model import result_status
10 from model.crash.chrome_crash_analysis import ChromeCrashAnalysis 11 from model.crash.chrome_crash_analysis import ChromeCrashAnalysis
11 12
12 13
13 class ChromeCrashAnalysisTest(PredatorTestCase): 14 class ChromeCrashAnalysisTest(PredatorTestCase):
14 15
15 def testDoNotUseIdentifiersToSetProperties(self): 16 def testDoNotUseIdentifiersToSetProperties(self):
16 crash_identifiers = { 17 crash_identifiers = {
(...skipping 10 matching lines...) Expand all
27 self.assertIsNone(analysis.channel) 28 self.assertIsNone(analysis.channel)
28 self.assertIsNone(analysis.platform) 29 self.assertIsNone(analysis.platform)
29 30
30 def testChromeCrashAnalysisReset(self): 31 def testChromeCrashAnalysisReset(self):
31 analysis = ChromeCrashAnalysis() 32 analysis = ChromeCrashAnalysis()
32 analysis.historical_metadata = {} 33 analysis.historical_metadata = {}
33 analysis.Reset() 34 analysis.Reset()
34 self.assertIsNone(analysis.channel) 35 self.assertIsNone(analysis.channel)
35 self.assertIsNone(analysis.historical_metadata) 36 self.assertIsNone(analysis.historical_metadata)
36 37
37 def testChromeCrashAnalysisCustomizedProperty(self): 38 def testInitializeWithCrashData(self):
39 findit = self.GetMockFindit()
40 channel = 'dummy channel'
41 historical_metadata = []
42 crash_data = self.GetDummyChromeCrashData(
43 channel=channel, historical_metadata=historical_metadata)
44 class MockChromeCrashData(ChromeCrashData):
45
46 def __init__(self, crash_data):
47 super(MockChromeCrashData, self).__init__(crash_data, None)
48
49 @property
50 def stacktrace(self):
51 return None
52
53 @property
54 def regression_range(self):
55 return None
56
57 @property
58 def dependencies(self):
59 return {}
60
61 @property
62 def dependency_rolls(self):
63 return {}
64
65 self.mock(findit, 'GetCrashData',
66 lambda crash_data: MockChromeCrashData( # pylint: disable=W0108
67 crash_data))
68
69 crash_data = findit.GetCrashData(crash_data)
38 analysis = ChromeCrashAnalysis() 70 analysis = ChromeCrashAnalysis()
39 analysis.historical_metadata = {'chrome_version': '50.0.1200.0', 71 analysis.Initialize(crash_data)
40 'cpm': 0.5} 72 self.assertEqual(analysis.channel, channel)
41 analysis.channel = 'canary' 73 self.assertEqual(analysis.historical_metadata, historical_metadata)
42 self.assertEqual(analysis.customized_data,
43 {'historical_metadata': {'chrome_version': '50.0.1200.0',
44 'cpm': 0.5},
45 'channel': 'canary'})
OLDNEW
« no previous file with comments | « appengine/findit/model/crash/crash_analysis.py ('k') | appengine/findit/model/crash/test/crash_analysis_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698