Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Unified Diff: appengine/findit/crash/test/changelist_classifier_test.py

Issue 2663063007: [Predator] Switch from anonymous dict to CrashData. (Closed)
Patch Set: Rebase and fix delta test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/changelist_classifier_test.py
diff --git a/appengine/findit/crash/test/changelist_classifier_test.py b/appengine/findit/crash/test/changelist_classifier_test.py
index c311878f1d6f1f9c7798dd60bd5ce48449d3774f..da410c50ab41086481800468c87d796df5850d01 100644
--- a/appengine/findit/crash/test/changelist_classifier_test.py
+++ b/appengine/findit/crash/test/changelist_classifier_test.py
@@ -126,8 +126,8 @@ DUMMY_CALLSTACKS = [
CallStack(0, [], CallStackFormatType.DEFAULT, LanguageType.CPP),
CallStack(1, [], CallStackFormatType.DEFAULT, LanguageType.CPP)]
DUMMY_REPORT = CrashReport(
- None, None, None, Stacktrace(DUMMY_CALLSTACKS, DUMMY_CALLSTACKS[0]),
- (None, None))
+ 'rev', 'sig', 'win', Stacktrace(DUMMY_CALLSTACKS, DUMMY_CALLSTACKS[0]),
+ (None, None), None, None)
class ChangelistClassifierTest(CrashTestSuite):
@@ -170,11 +170,14 @@ class ChangelistClassifierTest(CrashTestSuite):
self.mock(changelist_classifier, 'FindSuspects', lambda *_: None)
stack = CallStack(0)
- self.changelist_classifier(CrashReport(crashed_version = '5',
- signature = 'sig',
- platform = 'canary',
- stacktrace = Stacktrace([stack], stack),
- regression_range = ('4', '5')))
+ self.changelist_classifier(
+ CrashReport(crashed_version = '5',
+ signature = 'sig',
+ platform = 'canary',
+ stacktrace = Stacktrace([stack], stack),
+ regression_range = ('4', '5'),
+ dependencies = {},
+ dependency_rolls = {}))
expected_regression_deps_rolls = copy.deepcopy(dep_rolls)
# Regression of a dep added/deleted (old_revision/new_revision is None) can

Powered by Google App Engine
This is Rietveld 408576698