[Predator] Switch from anonymous dict to CrashData.

appengine/findit/crash/test/changelist_classifier_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import copy
 
 from common.dependency import Dependency
 from common.dependency import DependencyRoll
 from common import chrome_dependency_fetcher
@@ skipping 108 matching lines @@
 # since we mock GetDEPSRollsDict. So, really what we ought to do in the
 # long run is redesign things so that GetDEPSRollsDict takes the
 # CrashReport directly and pulls out the revision_range and platform
 # itself; that way ChangelistClassifier.__call__ needn't worry about it,
 # allowing us to clean up the tests here.
 
 DUMMY_CALLSTACKS = [
     CallStack(0, [], CallStackFormatType.DEFAULT, LanguageType.CPP),
     CallStack(1, [], CallStackFormatType.DEFAULT, LanguageType.CPP)]
 DUMMY_REPORT = CrashReport(
-    None, None, None, Stacktrace(DUMMY_CALLSTACKS, DUMMY_CALLSTACKS[0]),
-    (None, None))
+    'rev', 'sig', 'win', Stacktrace(DUMMY_CALLSTACKS, DUMMY_CALLSTACKS[0]),
+    (None, None), None, None)
 
 
 class ChangelistClassifierTest(CrashTestSuite):
 
   @property
   def _mock_http_gitiles_repo_factory(self):
     # N.B., we must return a lambda rather than taking ``repo_url``
     # as an additional argument to the method/property, to ensure that
     # things have the right arity when this is eventually called. That
     # is, we want a function of ``repo_url`` which closes over ``self``,
@@ skipping 22 matching lines @@
       passed_in_regression_deps_rolls.append(regression_deps_rolls)
       return {}, None
 
     self.mock(changelist_classifier, 'GetChangeLogsForFilesGroupedByDeps',
               _MockGetChangeLogsForFilesGroupedByDeps)
     self.mock(changelist_classifier, 'GetStackInfosForFilesGroupedByDeps',
               lambda *_: {})
     self.mock(changelist_classifier, 'FindSuspects', lambda *_: None)
 
     stack = CallStack(0)
-    self.changelist_classifier(CrashReport(crashed_version = '5',
-                               signature = 'sig',
-                               platform = 'canary',
-                               stacktrace = Stacktrace([stack], stack),
-                               regression_range = ('4', '5')))
+    self.changelist_classifier(
+        CrashReport(crashed_version = '5',
+                    signature = 'sig',
+                    platform = 'canary',
+                    stacktrace = Stacktrace([stack], stack),
+                    regression_range = ('4', '5'),
+                    dependencies = {},
+                    dependency_rolls = {}))
     expected_regression_deps_rolls = copy.deepcopy(dep_rolls)
 
     # Regression of a dep added/deleted (old_revision/new_revision is None) can
     # not be known for sure and this case rarely happens, so just filter them
     # out.
     del expected_regression_deps_rolls['src/dep']
     self.assertEqual(passed_in_regression_deps_rolls[0],
                      expected_regression_deps_rolls)
 
   def testGetDepsInCrashStack(self):
@@ skipping 317 matching lines @@
       return [suspect1, suspect2]
 
     self.mock(changelist_classifier, 'FindSuspects', _MockFindSuspects)
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict',
         lambda *_: {'src/': DependencyRoll('src/', 'https://repo', '1', '2')})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
 
     self.assertListEqual(self.changelist_classifier(DUMMY_REPORT), [])