Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2663063005: Revert of [wasm] include JS conformance tests in Wasm mjsunit tests (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] include JS conformance tests in Wasm mjsunit tests (patchset #5 id:80001 of https://codereview.chromium.org/2660903003/ ) Reason for revert: http://crbug.com/687279 Original issue's description: > [wasm] include JS conformance tests in Wasm mjsunit tests > > BUG= > > Review-Url: https://codereview.chromium.org/2660903003 > Cr-Commit-Position: refs/heads/master@{#42821} > Committed: https://chromium.googlesource.com/v8/v8/+/eb9b5edffb8c5acb0abdff0729901f95dbd3ccac TBR=mtrofin@chromium.org,titzer@chromium.org,bradnelson@chromium.org,eholk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2663063005 Cr-Commit-Position: refs/heads/master@{#42823} Committed: https://chromium.googlesource.com/v8/v8/+/c2e4eb29ccf9e6c7d32345ae6732e71f601d919a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -86 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.isolate View 1 chunk +2 lines, -3 lines 0 comments Download
D test/mjsunit/wasm/jsapi-harness.js View 1 chunk +0 lines, -78 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [wasm] include JS conformance tests in Wasm mjsunit tests
3 years, 10 months ago (2017-01-31 19:59:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663063005/1
3 years, 10 months ago (2017-01-31 19:59:24 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 19:59:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c2e4eb29ccf9e6c7d32345ae6732e71f601...

Powered by Google App Engine
This is Rietveld 408576698