Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: pkg/analyzer/lib/src/generated/error_verifier.dart

Issue 2663063004: Don't resolve FieldFormalParameter field if not in constructor. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/error_verifier.dart
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart
index 742a0a168d9145f5df570c80d1f73ea4375f5e35..52cf7dadc85eb6f3750c1cb52b05a79edad54f56 100644
--- a/pkg/analyzer/lib/src/generated/error_verifier.dart
+++ b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -5904,6 +5904,11 @@ class ErrorVerifier extends RecursiveAstVisitor<Object> {
}
void _checkForValidField(FieldFormalParameter parameter) {
+ AstNode parent2 = parameter.parent?.parent;
+ if (parent2 is! ConstructorDeclaration &&
+ parent2?.parent is! ConstructorDeclaration) {
+ return;
+ }
ParameterElement element = parameter.element;
if (element is FieldFormalParameterElement) {
FieldElement fieldElement = element.field;
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/element.dart ('k') | pkg/analyzer/test/src/summary/resynthesize_common.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698