Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: pkg/analyzer/lib/src/dart/element/element.dart

Issue 2663063004: Don't resolve FieldFormalParameter field if not in constructor. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/builder.dart ('k') | pkg/analyzer/lib/src/generated/error_verifier.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index 371b24e5e6b1f0c044fb4951ae967a149f96a34e..ecd8ec6ac82916ea699315c9d50859eab7b2b451 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -4314,13 +4314,14 @@ class FieldFormalParameterElementImpl extends ParameterElementImpl
@override
FieldElement get field {
if (_unlinkedParam != null && _field == null) {
- Element enclosing = enclosingElement?.enclosingElement;
- while (enclosing != null) {
- if (enclosing is ClassElement) {
- _field = enclosing.getField(_unlinkedParam.name);
- break;
- } else {
- enclosing = enclosing.enclosingElement;
+ Element enclosingConstructor = enclosingElement;
+ if (enclosingConstructor is ConstructorElement) {
+ Element enclosingClass = enclosingConstructor.enclosingElement;
+ if (enclosingClass is ClassElement) {
+ FieldElement field = enclosingClass.getField(_unlinkedParam.name);
+ if (field != null && !field.isSynthetic) {
+ _field = field;
+ }
}
}
}
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/builder.dart ('k') | pkg/analyzer/lib/src/generated/error_verifier.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698