Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2663063004: Don't resolve FieldFormalParameter field if not in constructor. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't resolve FieldFormalParameter field if not in constructor. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c74771b43d6681e71e82b92ad29f6c274b8cf782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -18 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 4 chunks +11 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-01-31 19:08:46 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-01-31 19:13:13 UTC) #2
scheglov
3 years, 10 months ago (2017-01-31 19:16:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c74771b43d6681e71e82b92ad29f6c274b8cf782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698