Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2662993002: [IntersectionObserver] Add isIntersecting field. (Closed)

Created:
3 years, 10 months ago by szager1
Modified:
3 years, 10 months ago
Reviewers:
esprehn, foolip, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[IntersectionObserver] Add isIntersecting field. Discussion here: https://github.com/WICG/IntersectionObserver/issues/69 R=ojan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2662993002 Cr-Commit-Position: refs/heads/master@{#448677} Committed: https://chromium.googlesource.com/chromium/src/+/2ff49b42058b3e5604498f6999b85f16bfc01116

Patch Set 1 #

Patch Set 2 : Update webexposed #

Patch Set 3 : more webexposed #

Patch Set 4 : webexposed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -43 lines) Patch
M third_party/WebKit/LayoutTests/intersection-observer/display-none.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/edge-inclusive-intersection.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/multiple-thresholds.html View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/remove-element.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/resources/intersection-observer-test-utils.js View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/resources/observer-in-iframe-subframe.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/root-margin.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/same-document-no-root.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/same-document-root.html View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/shadow-content.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/zero-area-element-hidden.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverEntry.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverEntry.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverEntry.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 35 (18 generated)
szager1
3 years, 10 months ago (2017-01-30 21:42:21 UTC) #1
szager1
ping
3 years, 10 months ago (2017-02-02 21:12:11 UTC) #2
szager1
ping
3 years, 10 months ago (2017-02-06 18:18:42 UTC) #5
ojan
lgtm
3 years, 10 months ago (2017-02-06 21:57:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662993002/1
3 years, 10 months ago (2017-02-06 21:58:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662993002/1
3 years, 10 months ago (2017-02-06 21:59:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/384654)
3 years, 10 months ago (2017-02-06 23:25:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662993002/20001
3 years, 10 months ago (2017-02-07 00:21:44 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/377380)
3 years, 10 months ago (2017-02-07 02:19:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662993002/40001
3 years, 10 months ago (2017-02-07 03:05:32 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/377488)
3 years, 10 months ago (2017-02-07 05:07:06 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662993002/60001
3 years, 10 months ago (2017-02-07 05:11:47 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/358203)
3 years, 10 months ago (2017-02-07 05:18:40 UTC) #27
szager1
+foolip for API_OWNERS
3 years, 10 months ago (2017-02-07 05:53:48 UTC) #29
foolip
lgtm
3 years, 10 months ago (2017-02-07 15:47:30 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662993002/60001
3 years, 10 months ago (2017-02-07 18:37:19 UTC) #32
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 18:43:14 UTC) #35
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2ff49b42058b3e5604498f6999b8...

Powered by Google App Engine
This is Rietveld 408576698