Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2662903002:
chromeos: Avoid shutdown for delayed power button events. (Closed)
|
Created:
3 years, 10 months ago by Daniel Erat Modified:
3 years, 10 months ago Reviewers:
Qiang(Joe) Xu CC:
chromium-reviews Target Ref:
refs/pending/branch-heads/2987 Project:
chromium Visibility:
Public. |
Descriptionchromeos: Avoid shutdown for delayed power button events.
powerd makes blocking D-Bus calls to Chrome to turn the display on or
off. When a power-button-down event turns the display on, this can
result in the corresponding power-button-up event being delayed, which
can then cause the system to be shut down prematurely.
As a hopefully low-risk workaround for this, make
TabletPowerButtonController wait 2000 (rather than 500) milliseconds
before starting the shutdown animation if the screen was off when the
power button was pressed.
BUG=685734
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2651313004
Cr-Commit-Position: refs/heads/master@{#446832}
(cherry picked from commit 97f83d816742eef5677384925fd92d10eaa7dc9a)
Review-Url: https://codereview.chromium.org/2662903002
Cr-Commit-Position: refs/branch-heads/2987@{#188}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/85d16735d1bdb59df1a1c229e8d381aa1a1a92f5
Patch Set 1 #
Messages
Total messages: 27 (14 generated)
The CQ bit was checked by derat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
derat@chromium.org changed reviewers: + warx@chromium.org
this is the same as before, but "git drover" failed (transient error, i think) so i'm trying to land it via the CQ, which appears to require an LGTM. mind giving one? :-)
On 2017/01/30 18:02:45, Daniel Erat wrote: > this is the same as before, but "git drover" failed (transient error, i think) > so i'm trying to land it via the CQ, which appears to require an LGTM. mind > giving one? :-) LGTM
The CQ bit was checked by derat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== chromeos: Avoid shutdown for delayed power button events. powerd makes blocking D-Bus calls to Chrome to turn the display on or off. When a power-button-down event turns the display on, this can result in the corresponding power-button-up event being delayed, which can then cause the system to be shut down prematurely. As a hopefully low-risk workaround for this, make TabletPowerButtonController wait 2000 (rather than 500) milliseconds before starting the shutdown animation if the screen was off when the power button was pressed. BUG=685734 Review-Url: https://codereview.chromium.org/2651313004 Cr-Commit-Position: refs/heads/master@{#446832} (cherry picked from commit 97f83d816742eef5677384925fd92d10eaa7dc9a) ========== to ========== chromeos: Avoid shutdown for delayed power button events. powerd makes blocking D-Bus calls to Chrome to turn the display on or off. When a power-button-down event turns the display on, this can result in the corresponding power-button-up event being delayed, which can then cause the system to be shut down prematurely. As a hopefully low-risk workaround for this, make TabletPowerButtonController wait 2000 (rather than 500) milliseconds before starting the shutdown animation if the screen was off when the power button was pressed. BUG=685734 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2651313004 Cr-Commit-Position: refs/heads/master@{#446832} (cherry picked from commit 97f83d816742eef5677384925fd92d10eaa7dc9a) ==========
The CQ bit was checked by derat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485809412111720, "parent_rev":
"4b3f65698baa64b20f07e341c19751803af8be1a", "commit_rev":
"0747c78c914257355bf40c2a443a6a261584c733"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485809412111720, "parent_rev":
"4b3f65698baa64b20f07e341c19751803af8be1a", "commit_rev":
"0747c78c914257355bf40c2a443a6a261584c733"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485809412111720, "parent_rev":
"4b3f65698baa64b20f07e341c19751803af8be1a", "commit_rev":
"0747c78c914257355bf40c2a443a6a261584c733"}
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
On 2017/01/30 21:01:30, commit-bot: I haz the power wrote: > Failed to commit the patch. hmm, that's quite the useless error message. now i'm wondering if the CQ doesn't know how to commit to branches...
The CQ bit was checked by derat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/30 21:30:16, Daniel Erat wrote: > On 2017/01/30 21:01:30, commit-bot: I haz the power wrote: > > Failed to commit the patch. > > hmm, that's quite the useless error message. now i'm wondering if the CQ doesn't > know how to commit to branches... can we do this way for back merge? In my mind, that needs git cl land.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485811823266960, "parent_rev":
"45dcaa149c4eea6fb0bab9467f3e4e1506714254", "commit_rev":
"85d16735d1bdb59df1a1c229e8d381aa1a1a92f5"}
Message was sent while issue was closed.
Description was changed from ========== chromeos: Avoid shutdown for delayed power button events. powerd makes blocking D-Bus calls to Chrome to turn the display on or off. When a power-button-down event turns the display on, this can result in the corresponding power-button-up event being delayed, which can then cause the system to be shut down prematurely. As a hopefully low-risk workaround for this, make TabletPowerButtonController wait 2000 (rather than 500) milliseconds before starting the shutdown animation if the screen was off when the power button was pressed. BUG=685734 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2651313004 Cr-Commit-Position: refs/heads/master@{#446832} (cherry picked from commit 97f83d816742eef5677384925fd92d10eaa7dc9a) ========== to ========== chromeos: Avoid shutdown for delayed power button events. powerd makes blocking D-Bus calls to Chrome to turn the display on or off. When a power-button-down event turns the display on, this can result in the corresponding power-button-up event being delayed, which can then cause the system to be shut down prematurely. As a hopefully low-risk workaround for this, make TabletPowerButtonController wait 2000 (rather than 500) milliseconds before starting the shutdown animation if the screen was off when the power button was pressed. BUG=685734 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2651313004 Cr-Commit-Position: refs/heads/master@{#446832} (cherry picked from commit 97f83d816742eef5677384925fd92d10eaa7dc9a) Review-Url: https://codereview.chromium.org/2662903002 Cr-Commit-Position: refs/branch-heads/2987@{#188} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/85d16735d1bdb59df1a1c229e8d3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/85d16735d1bdb59df1a1c229e8d3...
Message was sent while issue was closed.
On 2017/01/30 21:34:03, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/85d16735d1bdb59df1a1c229e8d3... hmm. i guess it works. :-) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
