Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2662883003: Add a test for OptimizingCompileDispatcher::Flush's non-blocking behavior (Closed)

Created:
3 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a test for OptimizingCompileDispatcher::Flush's non-blocking behavior R=mtrofin@chromium.org,verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2662883003 Cr-Commit-Position: refs/heads/master@{#42787} Committed: https://chromium.googlesource.com/v8/v8/+/d651ce314c4e0c20dd1e35d5a5d7994db76bcbe2

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -20 lines) Patch
M src/base/atomic-utils.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compilation-info.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler-dispatcher/optimizing-compile-dispatcher.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/compiler-dispatcher/optimizing-compile-dispatcher.cc View 3 chunks +14 lines, -15 lines 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A test/unittests/compiler-dispatcher/optimizing-compile-dispatcher-unittest.cc View 1 chunk +98 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
jochen (gone - plz use gerrit)
3 years, 10 months ago (2017-01-30 18:02:36 UTC) #1
Mircea Trofin
lgtm
3 years, 10 months ago (2017-01-30 19:17:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662883003/20001
3 years, 10 months ago (2017-01-30 19:25:23 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 19:27:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d651ce314c4e0c20dd1e35d5a5d7994db76...

Powered by Google App Engine
This is Rietveld 408576698