Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2662863002: Add typ boilerplate to Telemetry-based GPU tests. (Closed)

Created:
3 years, 10 months ago by nednguyen
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add typ boilerplate to Telemetry-based GPU tests. The typ based browser_test_runner framework requires every browser test module to explicitly declares test module generation in the load_tests() method. This CL as those boiler plates code to prepare for changing browser_test_runner to use typ as the runner. This depends on https://codereview.chromium.org/2660913002 to avoid gpu unittests from accidentally picking up those load_tests() method. BUG=636153 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2662863002 Cr-Commit-Position: refs/heads/master@{#447059} Committed: https://chromium.googlesource.com/chromium/src/+/44521e985457606bb56e05fbdd45e94bbe3e656f

Patch Set 1 #

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662863002/1
3 years, 10 months ago (2017-01-30 19:38:25 UTC) #4
Ken Russell (switch to Gerrit)
lgtm
3 years, 10 months ago (2017-01-30 19:43:48 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 21:06:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44521e985457606bb56e05fbdd45...

Powered by Google App Engine
This is Rietveld 408576698