Chromium doesn't compile with -Wglobal-constructors

Chromium doesn't compile with -Wglobal-constructors

We compile chromium with clang flag -Wglobal-constructors in our
project. We have following compilation error during compilation
of user_input_tracker.cc:

../../chrome/browser/page_load_metrics/user_input_tracker.cc:27:11:
error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
const int kRateLimitClampMillis = (kOldestAllowedEventAgeSeconds * 1000) /

In order to get rid of this global constructor I recommend to declare
static class variable UserInputTracker::kMaxTrackedEvents and global
variable kRateLimitClampMillis as constexpr which will be expanded to
numerical value during compilation.

BUG=686669
Review-Url: https://codereview.chromium.org/2662803002
Cr-Commit-Position: refs/heads/master@{#447000}
Committed: https://chromium.googlesource.com/chromium/src/+/656950c2f6ebeae22139d9753eca81f213c74b53

[ckulakowski, 2017-01-30 11:08:43]

Description was changed from

==========
Chromium doesn't compile with -Wglobal-constructors

We compile chromium with clang flag -Wglobal-constructors in our
project. We have following compilation error during compilation
of user_input_tracker.cc:

../../chrome/browser/page_load_metrics/user_input_tracker.cc:27:11:
error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
const int kRateLimitClampMillis = (kOldestAllowedEventAgeSeconds * 1000) /

In order to get rid of this global constructor I recommend to declare
static class variable UserInputTracker::kMaxTrackedEvents and global
variable kRateLimitClampMillis as constexpr which will be expanded to
numerical value during compilation.

BUG=686669
==========

to

==========
Chromium doesn't compile with -Wglobal-constructors

We compile chromium with clang flag -Wglobal-constructors in our
project. We have following compilation error during compilation
of user_input_tracker.cc:

../../chrome/browser/page_load_metrics/user_input_tracker.cc:27:11:
error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
const int kRateLimitClampMillis = (kOldestAllowedEventAgeSeconds * 1000) /

In order to get rid of this global constructor I recommend to declare
static class variable UserInputTracker::kMaxTrackedEvents and global
variable kRateLimitClampMillis as constexpr which will be expanded to
numerical value during compilation.

BUG=686669
==========

[ckulakowski, 2017-01-30 11:08:43]

ckulakowski@opera.com changed reviewers:
+ ryansturm@chromium.org

[Charlie Harrison, 2017-01-30 14:17:51]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2017-01-30 14:17:51]

drive-by lgtm

https://codereview.chromium.org/2662803002/diff/1/chrome/browser/page_load_me...
File chrome/browser/page_load_metrics/user_input_tracker.cc (right):

https://codereview.chromium.org/2662803002/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/user_input_tracker.cc:66: constexpr size_t
UserInputTracker::kMaxTrackedEvents;
Can you move this bit of code nearer to the kRateLimitClampMillis definition? I
assume that's the only place we need this to be constexpr.

[ckulakowski, 2017-01-30 15:46:56]

https://codereview.chromium.org/2662803002/diff/1/chrome/browser/page_load_me...
File chrome/browser/page_load_metrics/user_input_tracker.cc (right):

https://codereview.chromium.org/2662803002/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/user_input_tracker.cc:66: constexpr size_t
UserInputTracker::kMaxTrackedEvents;
On 2017/01/30 14:17:51, Charlie Harrison wrote:
> Can you move this bit of code nearer to the kRateLimitClampMillis definition?
I
> assume that's the only place we need this to be constexpr.

Done.

[ckulakowski, 2017-01-30 15:48:45]

The CQ bit was checked by ckulakowski@opera.com

[ckulakowski, 2017-01-30 15:48:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2662803002/#ps20001
(title: "Change for request from review.")

[commit-bot: I haz the power, 2017-01-30 15:48:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 16:42:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485791325019700,
"parent_rev": "27392dadd471377c10736953fedbb18f76cbf2e8", "commit_rev":
"656950c2f6ebeae22139d9753eca81f213c74b53"}

[commit-bot: I haz the power, 2017-01-30 16:43:28]

Description was changed from

==========
Chromium doesn't compile with -Wglobal-constructors

We compile chromium with clang flag -Wglobal-constructors in our
project. We have following compilation error during compilation
of user_input_tracker.cc:

../../chrome/browser/page_load_metrics/user_input_tracker.cc:27:11:
error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
const int kRateLimitClampMillis = (kOldestAllowedEventAgeSeconds * 1000) /

In order to get rid of this global constructor I recommend to declare
static class variable UserInputTracker::kMaxTrackedEvents and global
variable kRateLimitClampMillis as constexpr which will be expanded to
numerical value during compilation.

BUG=686669
==========

to

==========
Chromium doesn't compile with -Wglobal-constructors

We compile chromium with clang flag -Wglobal-constructors in our
project. We have following compilation error during compilation
of user_input_tracker.cc:

../../chrome/browser/page_load_metrics/user_input_tracker.cc:27:11:
error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
const int kRateLimitClampMillis = (kOldestAllowedEventAgeSeconds * 1000) /

In order to get rid of this global constructor I recommend to declare
static class variable UserInputTracker::kMaxTrackedEvents and global
variable kRateLimitClampMillis as constexpr which will be expanded to
numerical value during compilation.

BUG=686669

Review-Url: https://codereview.chromium.org/2662803002
Cr-Commit-Position: refs/heads/master@{#447000}
Committed:
https://chromium.googlesource.com/chromium/src/+/656950c2f6ebeae22139d9753eca...
==========

[commit-bot: I haz the power, 2017-01-30 16:43:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/656950c2f6ebeae22139d9753eca...