Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2662793002: [turbofan] Don't constant-fold ACCESSOR properties. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't constant-fold ACCESSOR properties. R=ishell@chromium.org BUG=chromium:686102 Review-Url: https://codereview.chromium.org/2662793002 Cr-Commit-Position: refs/heads/master@{#42767} Committed: https://chromium.googlesource.com/v8/v8/+/b91285165045358a633c794873c177982d43ad73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +10 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-686102.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 10 months ago (2017-01-30 10:44:33 UTC) #1
Igor Sheludko
lgtm
3 years, 10 months ago (2017-01-30 10:50:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662793002/1
3 years, 10 months ago (2017-01-30 10:51:45 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 11:15:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b91285165045358a633c794873c177982d4...

Powered by Google App Engine
This is Rietveld 408576698