Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2662673002: Restrict the set of WoSign/StartCom certs to the Alexa Top 1M (Closed)

Created:
3 years, 10 months ago by Ryan Sleevi
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Restrict the set of WoSign/StartCom certs to the Alexa Top 1M Restrict the set of domains for which WoSign/StartCom certificates are trusted to the set of domains intersecting the Alexa Top 1M whose certificates are unexpired and unrevoked. BUG=685826 Review-Url: https://codereview.chromium.org/2613833002 Cr-Commit-Position: refs/heads/master@{#446501} (cherry picked from commit a4912183cbef2f2e76654467db74cf7d79b5052e) Review-Url: https://codereview.chromium.org/2662673002 . Cr-Commit-Position: refs/branch-heads/2987@{#153} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e719fc626a3b9a528bf226b704785bcb24d07868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16940 lines, -14 lines) Patch
M net/BUILD.gn View 3 chunks +17 lines, -0 lines 0 comments Download
M net/cert/cert_verify_proc.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verify_proc_whitelist.h View 2 chunks +12 lines, -2 lines 0 comments Download
M net/cert/cert_verify_proc_whitelist.cc View 2 chunks +57 lines, -9 lines 0 comments Download
M net/cert/cert_verify_proc_whitelist_unittest.cc View 2 chunks +67 lines, -2 lines 0 comments Download
A net/cert/cert_verify_proc_whitelist_unittest1.gperf View 1 chunk +9 lines, -0 lines 0 comments Download
A net/data/ssl/wosign/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A net/data/ssl/wosign/wosign_domains.gperf View 1 chunk +16759 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ryan Sleevi
3 years, 10 months ago (2017-01-27 21:15:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e719fc626a3b9a528bf226b704785bcb24d07868.

Powered by Google App Engine
This is Rietveld 408576698