Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2662623003: Enable download home by default (Closed)

Created:
3 years, 10 months ago by qinmin
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer, gone
CC:
chromium-reviews, asanka, jdonnelly+watch_chromium.org, ntp-dev+reviews_chromium.org, noyau+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Enable download home by default enable this for M57 and beyond BUG=685317 TBR=dfalcantara@chromium.org,bauerb@chromium.org Review-Url: https://codereview.chromium.org/2651233002 Cr-Commit-Position: refs/heads/master@{#446420} (cherry picked from commit 2476c81a93b0cb04c10c8186308fbb5cf1271627) Review-Url: https://codereview.chromium.org/2662623003 . Cr-Commit-Position: refs/branch-heads/2987@{#158} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/941930450b33b6437c479f7129493d9ff994397e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -78 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 1 chunk +9 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java View 4 chunks +0 lines, -25 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java View 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
3 years, 10 months ago (2017-01-27 22:33:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
941930450b33b6437c479f7129493d9ff994397e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698