Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2662583003: Clean up device/vr BUILD file. (Closed)

Created:
3 years, 10 months ago by mthiesse
Modified:
3 years, 10 months ago
Reviewers:
clamy, bajones
CC:
chromium-reviews, jam, feature-vr-reviews_chromium.org, darin-cc_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up device/vr BUILD file. BUG= Review-Url: https://codereview.chromium.org/2662583003 Cr-Commit-Position: refs/heads/master@{#447159} Committed: https://chromium.googlesource.com/chromium/src/+/668cd6d2d2a73caa5447fbd68a89e55703e1d089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -27 lines) Patch
M content/browser/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/vr/BUILD.gn View 4 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mthiesse
bajones@chromium.org: Please review changes in device/ clamy@chromium.org: Please review changes in content/
3 years, 10 months ago (2017-01-27 17:19:09 UTC) #4
bajones
On 2017/01/27 17:19:09, mthiesse wrote: > mailto:bajones@chromium.org: Please review changes in device/ > > mailto:clamy@chromium.org: ...
3 years, 10 months ago (2017-01-27 20:36:07 UTC) #7
clamy
Thanks for the cleanup! content/ lgtm.
3 years, 10 months ago (2017-01-31 00:21:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662583003/1
3 years, 10 months ago (2017-01-31 00:40:16 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 01:58:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/668cd6d2d2a73caa5447fbd68a89...

Powered by Google App Engine
This is Rietveld 408576698