Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2662583002: [ios] Disables ToolbarTestCase.testCopyPasteURL on device. (Closed)

Created:
3 years, 10 months ago by rohitrao (ping after 24h)
Modified:
3 years, 10 months ago
Reviewers:
baxley, gambard
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Disables ToolbarTestCase.testCopyPasteURL on iOS 9. BUG=686069 Review-Url: https://codereview.chromium.org/2662583002 Cr-Commit-Position: refs/heads/master@{#446692} Committed: https://chromium.googlesource.com/chromium/src/+/29215937d2b774363840defec3d752ffed112655

Patch Set 1 #

Patch Set 2 : Update comment. #

Patch Set 3 : iOS9 #

Total comments: 3

Patch Set 4 : Format. #

Patch Set 5 : Use macro and fix test name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ui/toolbar/toolbar_egtest.mm View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
rohitrao (ping after 24h)
3 years, 10 months ago (2017-01-27 16:20:10 UTC) #2
gambard
lgtm but you are not checking for iOS version also?
3 years, 10 months ago (2017-01-27 16:21:49 UTC) #3
baxley
lgtm
3 years, 10 months ago (2017-01-27 16:34:06 UTC) #6
baxley
lgtm https://codereview.chromium.org/2662583002/diff/40001/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm File ios/chrome/browser/ui/toolbar/toolbar_egtest.mm (right): https://codereview.chromium.org/2662583002/diff/40001/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm#newcode279 ios/chrome/browser/ui/toolbar/toolbar_egtest.mm:279: - (void)MAYBE_testCopyPasteURL { remove MAYBE_ https://codereview.chromium.org/2662583002/diff/40001/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm#newcode279 ios/chrome/browser/ui/toolbar/toolbar_egtest.mm:279: - ...
3 years, 10 months ago (2017-01-27 16:41:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662583002/80001
3 years, 10 months ago (2017-01-27 16:48:52 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 16:59:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/29215937d2b774363840defec3d7...

Powered by Google App Engine
This is Rietveld 408576698