|
|
Chromium Code Reviews
DescriptionConvert NavigationControllerBrowserTest to use the new navigation callbacks.
BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2662533002
Cr-Commit-Position: refs/heads/master@{#446790}
Committed: https://chromium.googlesource.com/chromium/src/+/f998a5e1f13847384ddc3574d549b2759fcca04c
Patch Set 1 #
Messages
Total messages: 18 (14 generated)
Description was changed from ========== Convert NavigationControllerBrowserTest to use the new navigation callbacks. BUG=682002 ========== to ========== Convert NavigationControllerBrowserTest to use the new navigation callbacks. BUG=682002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
jam@chromium.org changed reviewers: + nasko@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485553467278370,
"parent_rev": "1973beba8eb5419f66f3ec9e685c7c257781ff36", "commit_rev":
"f998a5e1f13847384ddc3574d549b2759fcca04c"}
Message was sent while issue was closed.
Description was changed from ========== Convert NavigationControllerBrowserTest to use the new navigation callbacks. BUG=682002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Convert NavigationControllerBrowserTest to use the new navigation callbacks. BUG=682002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2662533002 Cr-Commit-Position: refs/heads/master@{#446790} Committed: https://chromium.googlesource.com/chromium/src/+/f998a5e1f13847384ddc3574d549... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f998a5e1f13847384ddc3574d549... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
