Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2662513005: bluetooth: Change internal page style to increase contrast of UI elements (Closed)

Created:
3 years, 10 months ago by mbrunson
Modified:
3 years, 10 months ago
Reviewers:
scheib, ortuno, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Change internal page style to increase contrast of UI elements Adds colors to list items so differentiating between list types is easier. Removes padding on the edge of list items to fit more content in expandable list area. Adds spacing between device table rows in the mobile layout. Darkens divider lines in list and table. Screenshots: https://goo.gl/photos/9cDMF9w1FfXymxXX8 BUG=651282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2662513005 Cr-Commit-Position: refs/heads/master@{#446884} Committed: https://chromium.googlesource.com/chromium/src/+/8f191348744018beaea0aea98312b50cf7c90123

Patch Set 1 #

Patch Set 2 : Remove blank line #

Patch Set 3 : Change descriptor list color to darkest blue #

Patch Set 4 : Lighten removed row color to increase text contrast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -17 lines) Patch
M chrome/browser/resources/bluetooth_internals/bluetooth_internals.css View 1 2 3 9 chunks +46 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mbrunson
3 years, 10 months ago (2017-01-27 21:56:52 UTC) #3
ortuno
lgtm
3 years, 10 months ago (2017-01-27 22:50:23 UTC) #4
Dan Beam
i don't really know how this looked before, but it's probably better with this CL ...
3 years, 10 months ago (2017-01-27 23:56:29 UTC) #5
scheib
lgtm
3 years, 10 months ago (2017-01-28 00:43:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662513005/60001
3 years, 10 months ago (2017-01-28 00:47:25 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 02:11:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8f191348744018beaea0aea98312...

Powered by Google App Engine
This is Rietveld 408576698