Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2662463002: Convert NavigationControllerBrowserTest to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert NavigationControllerBrowserTest to use the new navigation callbacks. BUG=682002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2662463002 Cr-Commit-Position: refs/heads/master@{#446520} Committed: https://chromium.googlesource.com/chromium/src/+/80cd4e0be56d5861cd75ee70197be02c18d5217e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-01-26 23:00:28 UTC) #5
nasko
LGTM
3 years, 10 months ago (2017-01-27 00:23:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662463002/1
3 years, 10 months ago (2017-01-27 00:38:45 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 01:20:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/80cd4e0be56d5861cd75ee70197b...

Powered by Google App Engine
This is Rietveld 408576698