Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2662453004: DevTools: Update network overview with two level bars. (Closed)

Created:
3 years, 11 months ago by alph
Modified:
3 years, 10 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Update network overview with two level bars. BUG=686123 Review-Url: https://codereview.chromium.org/2662453004 Cr-Commit-Position: refs/heads/master@{#446792} Committed: https://chromium.googlesource.com/chromium/src/+/6bb8c1843f4526a7177671d5de8e4d547b40ef17

Patch Set 1 #

Total comments: 3

Patch Set 2 : 4 landing #

Patch Set 3 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -66 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 2 1 chunk +22 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js View 1 chunk +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
alph
3 years, 11 months ago (2017-01-27 00:48:55 UTC) #2
caseq
lgtm https://codereview.chromium.org/2662453004/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/2662453004/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode160 third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js:160: var height = this.height(); inline below. https://codereview.chromium.org/2662453004/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode161 third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js:161: ...
3 years, 11 months ago (2017-01-27 00:55:20 UTC) #3
alph
all done
3 years, 11 months ago (2017-01-27 01:17:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662453004/20001
3 years, 11 months ago (2017-01-27 01:17:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/379277)
3 years, 11 months ago (2017-01-27 04:58:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662453004/20001
3 years, 10 months ago (2017-01-27 16:51:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/379682)
3 years, 10 months ago (2017-01-27 19:27:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662453004/40001
3 years, 10 months ago (2017-01-27 20:21:17 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 22:21:59 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6bb8c1843f4526a7177671d5de8e...

Powered by Google App Engine
This is Rietveld 408576698