Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2662453002: Disable fullscreen/full-screen-iframe-zIndex.html test. (Closed)

Created:
3 years, 10 months ago by erikchen
Modified:
3 years, 10 months ago
Reviewers:
esprehn, foolip
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable fullscreen/full-screen-iframe-zIndex.html test. The test currently passes, but fails when the feature "Stop creating layout objects for elements inside display: none iframes" is enabled. The root cause is a long-standing fullscreen issue, see minimized repro in crbug.com/676432. The issue is likely going to go away with "migrate fullscreen to use top layer". BUG=676432, 650433, 240576 Review-Url: https://codereview.chromium.org/2662453002 Cr-Commit-Position: refs/heads/master@{#448067} Committed: https://chromium.googlesource.com/chromium/src/+/d8f04daf8b30d368349191fc0522e05c1dc32a98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
erikchen
esprehn, foolip: Thoughts? I'm a little bit wary of just disabling the test, since my ...
3 years, 10 months ago (2017-01-26 22:38:04 UTC) #2
foolip
I am about to revert a big change in https://codereview.chromium.org/2654083006/ which I don't think should ...
3 years, 10 months ago (2017-01-27 06:16:13 UTC) #3
esprehn
lgtm
3 years, 10 months ago (2017-02-01 05:22:19 UTC) #4
erikchen
I've verified that the root cause is still present after your revert. [repro steps: https://bugs.chromium.org/p/chromium/issues/detail?id=676432]
3 years, 10 months ago (2017-02-03 18:37:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662453002/1
3 years, 10 months ago (2017-02-03 18:37:30 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 20:49:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8f04daf8b30d368349191fc0522...

Powered by Google App Engine
This is Rietveld 408576698