Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 2662443003: Fix treatment of layout overflow rect in ScrollAnchor bounds computation. (Closed)

Created:
3 years, 11 months ago by skobes
Modified:
3 years, 11 months ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix treatment of layout overflow rect in ScrollAnchor bounds computation. The relativeBounds helper assumed the anchor candidate's layout overflow rect was positioned at 0,0 in its local coordinate space, but this is not always the case, e.g. if positioned children have negative offsets. BUG=685725 Review-Url: https://codereview.chromium.org/2662443003 Cr-Commit-Position: refs/heads/master@{#446485} Committed: https://chromium.googlesource.com/chromium/src/+/9bcdced388956bfc8c137cfd20c830d30748946d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
skobes
3 years, 11 months ago (2017-01-26 20:36:34 UTC) #4
szager1
lgtm
3 years, 11 months ago (2017-01-26 21:54:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662443003/1
3 years, 11 months ago (2017-01-26 23:00:52 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 23:08:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9bcdced388956bfc8c137cfd20c8...

Powered by Google App Engine
This is Rietveld 408576698