Add BluetoothRemoteGATTDescriptor reporting for .writeValue().

Add BluetoothRemoteGATTDescriptor reporting for .writeValue().

Similar to reporting for descriptor.writeValue(), this cl will add outcome
reporting for descriptor.writeValue allowing us to better understand how common errors in the field happen.

BUG=667319
R=

Review-Url: https://codereview.chromium.org/2662433003
Cr-Commit-Position: refs/heads/master@{#447533}
Committed: https://chromium.googlesource.com/chromium/src/+/beca21a195468bfa60a22f18e77de14bd00496b6

[dougt, 2017-01-26 23:44:57]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 23:46:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 00:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:46:06]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[dougt, 2017-01-27 23:30:07]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 23:30:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 04:02:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 04:02:41]

Dry run: This issue passed the CQ dry run.

[dougt, 2017-01-31 00:32:33]

dougt@chromium.org changed reviewers:
+ isherman@chromium.org, ortuno@chromium.org

[dougt, 2017-01-31 00:32:33]

ortuno, ptal.

isherman, ptal tools/metrics/histograms/histograms.xml

[Ilya Sherman, 2017-01-31 00:51:25]

histograms lgtm

[ortuno, 2017-01-31 19:11:52]

lgtm bar one nit

https://codereview.chromium.org/2662433003/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_metrics.cc (right):

https://codereview.chromium.org/2662433003/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_metrics.cc:375: 
nit: remove unnecessary line.

[ortuno, 2017-01-31 19:12:33]

https://codereview.chromium.org/2662433003/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_metrics.h (right):

https://codereview.chromium.org/2662433003/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_metrics.h:300: // Records the outcome of a
cache query for readValue. Should only be called if
oops, missed this. This should be writeValue.

[dougt, 2017-01-31 21:01:23]

https://codereview.chromium.org/2662433003/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_metrics.h (right):

https://codereview.chromium.org/2662433003/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_metrics.h:300: // Records the outcome of a
cache query for readValue. Should only be called if
On 2017/01/31 19:12:33, ortuno wrote:
> oops, missed this. This should be writeValue.

Done.

[ortuno, 2017-01-31 23:50:37]

https://codereview.chromium.org/2662433003/diff/40001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_metrics.h (right):

https://codereview.chromium.org/2662433003/diff/40001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_metrics.h:290: // Records the outcome of a
cache query for writeValue. Should only be called if
You changed the wrong comment hehe. This should be readValue. The one in the new
code should be writeValue.

[dougt, 2017-01-31 23:54:06]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[dougt, 2017-01-31 23:54:35]

https://codereview.chromium.org/2662433003/diff/40001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_metrics.h (right):

https://codereview.chromium.org/2662433003/diff/40001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_metrics.h:290: // Records the outcome of a
cache query for writeValue. Should only be called if
On 2017/01/31 23:50:37, ortuno wrote:
> You changed the wrong comment hehe. This should be readValue. The one in the
new
> code should be writeValue.

yup. :/

[commit-bot: I haz the power, 2017-01-31 23:54:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 03:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 03:37:51]

Dry run: This issue passed the CQ dry run.

[dougt, 2017-02-01 16:17:01]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-02-01 16:17:02]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2662433003/#ps60001
(title: "updating comments")

[commit-bot: I haz the power, 2017-02-01 16:17:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 16:28:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485965821519860,
"parent_rev": "29737c4cebfbc36f45d26148a6b2a42f3d1c7069", "commit_rev":
"beca21a195468bfa60a22f18e77de14bd00496b6"}

[commit-bot: I haz the power, 2017-02-01 16:29:34]

Description was changed from

==========
Add BluetoothRemoteGATTDescriptor reporting for .writeValue().

Similar to reporting for descriptor.writeValue(), this cl will add outcome
reporting for descriptor.writeValue allowing us to better understand how common
errors in the field happen.

BUG=667319
R=
==========

to

==========
Add BluetoothRemoteGATTDescriptor reporting for .writeValue().

Similar to reporting for descriptor.writeValue(), this cl will add outcome
reporting for descriptor.writeValue allowing us to better understand how common
errors in the field happen.

BUG=667319
R=

Review-Url: https://codereview.chromium.org/2662433003
Cr-Commit-Position: refs/heads/master@{#447533}
Committed:
https://chromium.googlesource.com/chromium/src/+/beca21a195468bfa60a22f18e77d...
==========

[commit-bot: I haz the power, 2017-02-01 16:29:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/beca21a195468bfa60a22f18e77d...