Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2662393004: [iwyu] Minor iwyu fixes. (Closed)

Created:
3 years, 10 months ago by marja
Modified:
3 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[iwyu] Minor iwyu fixes. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2662393004 Cr-Commit-Position: refs/heads/master@{#42857} Committed: https://chromium.googlesource.com/v8/v8/+/a6e24607f6400ff204a2a7fbfa1f56210cce6c41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/ast/modules.h View 2 chunks +1 line, -1 line 0 comments Download
M src/ast/modules.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
marja
ptal - Just fixing some random stuff I coincidentally noticed when debugging an unrelated bug. ...
3 years, 10 months ago (2017-02-01 13:42:26 UTC) #2
Michael Starzinger
LGTM.
3 years, 10 months ago (2017-02-01 14:31:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662393004/1
3 years, 10 months ago (2017-02-01 14:44:39 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 14:46:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a6e24607f6400ff204a2a7fbfa1f56210cc...

Powered by Google App Engine
This is Rietveld 408576698