Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2662363003: [wasm] Remove -0 -x = -x folding because of signalling NaNs. (Closed)

Created:
3 years, 10 months ago by ahaas
Modified:
3 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove -0 -x = -x folding because of signalling NaNs. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2662363003 Cr-Commit-Position: refs/heads/master@{#42902} Committed: https://chromium.googlesource.com/v8/v8/+/1b116567dd6df24b09b5340f5bb4a4d89255c0e8

Patch Set 1 #

Patch Set 2 : Also change Float32Sub #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M src/compiler/machine-operator-reducer.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/float-constant-folding.js View 1 2 3 3 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
ahaas
3 years, 10 months ago (2017-02-01 10:17:28 UTC) #1
titzer
lgtm
3 years, 10 months ago (2017-02-01 15:33:49 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2662233002 Patch 40001). Please resolve the dependency and ...
3 years, 10 months ago (2017-02-02 20:22:04 UTC) #11
commit-bot: I haz the power
This CL has an open dependency (Issue 2662233002 Patch 40001). Please resolve the dependency and ...
3 years, 10 months ago (2017-02-02 21:15:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662363003/60001
3 years, 10 months ago (2017-02-02 21:16:58 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 22:35:02 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/1b116567dd6df24b09b5340f5bb4a4d8925...

Powered by Google App Engine
This is Rietveld 408576698