Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 2662313003: Invalidate subsequence caching & empty paint phases if clips changed. (Closed)

Created:
3 years, 10 months ago by chrishtr
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate subsequence caching & empty paint phases if clips changed. Subsequence caching & empty paint phase optimizations need to be invalidated i any ancestor clips updated, since those clips are used to: a. Adjust painted output (SPInvalidation only, not SPv2), and b. Cull out invisible content (SPInvalidation and SPv2) Previously, we detected that by computing clip rects during paint. This CL moves it to the pre-paint tree walk. The CL does not yet work for SPv2, because it does not include computation of the enclosing transformed ancestor, which will be the SPv2 analogue of paintInvalidationContainer. BUG=683733 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 patch from issue 2654643002 at patchset 120001 (http://crrev.com/2654643002#ps120001)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -14 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 6 chunks +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h View 2 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 5 chunks +121 lines, -2 lines 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698