Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 2662313003: Invalidate subsequence caching & empty paint phases if clips changed. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
index 71ca7ffce91824c526d46d28b7951f5b043bc3f2..063bce36ec846324a9862151966ec8b2671e8c90 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
@@ -226,9 +226,8 @@ static bool shouldRepaintSubsequence(
needsRepaint = true;
// Repaint if layer's clip changes.
- // TODO(chrishtr): implement detecting clipping changes in SPv2.
- // crbug.com/645667
- if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+ if (!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
+ LOG(ERROR) << "oh";
ClipRects& clipRects = paintLayer.clipper().paintingClipRects(
paintingInfo.rootLayer, respectOverflowClip, subpixelAccumulation);
ClipRects* previousClipRects = paintLayer.previousPaintingClipRects();

Powered by Google App Engine
This is Rietveld 408576698