Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2662303003: Some small tweaks to getInstalledRelatedApps IDL files. (Closed)

Created:
3 years, 10 months ago by Matt Giuca
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Some small tweaks to getInstalledRelatedApps IDL files. User-visible change: RelatedApplication is no longer a visible interface. It doesn't need to be (and in fact should probably just be a dictionary). Only affects an unreleased API behind a flag. Also adds an idlharness test that runs basic tests over the interface. Also updated comments and added TODOs. BUG=687444 Review-Url: https://codereview.chromium.org/2662303003 Cr-Commit-Position: refs/heads/master@{#447720} Committed: https://chromium.googlesource.com/chromium/src/+/952ec0e36758c881a1e7a388895eb61d0d840817

Patch Set 1 #

Patch Set 2 : Removed RelatedApplication from global-interface-listing-expected.txt. #

Messages

Total messages: 17 (9 generated)
Matt Giuca
In preparation for landing https://codereview.chromium.org/2488573002/ and adding proper layout tests for this API. (The NoInterfaceObject ...
3 years, 10 months ago (2017-02-01 05:03:17 UTC) #2
haraken
LGTM
3 years, 10 months ago (2017-02-01 05:06:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662303003/1
3 years, 10 months ago (2017-02-01 05:47:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/374371)
3 years, 10 months ago (2017-02-01 07:18:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662303003/20001
3 years, 10 months ago (2017-02-02 00:21:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/382227)
3 years, 10 months ago (2017-02-02 04:57:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662303003/20001
3 years, 10 months ago (2017-02-02 06:26:29 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 07:41:42 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/952ec0e36758c881a1e7a388895e...

Powered by Google App Engine
This is Rietveld 408576698