📰 Handle optional item in group dismissal

[NTP Client] Handle optional item in group dismissal

Makes the suggestion section properly dismiss a single item
when the it does not show an action item.

BUG=687092
Review-Url: https://codereview.chromium.org/2662293002
Cr-Commit-Position: refs/heads/master@{#447276}
Committed: https://chromium.googlesource.com/chromium/src/+/3ea8c007ce51f08fcc6429be7957e3d75627d8e9

[dgn, 2017-01-31 17:16:07]

dgn@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[dgn, 2017-01-31 17:16:08]

PTAL

[dgn, 2017-01-31 17:16:14]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 17:16:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2017-01-31 17:17:56]

https://codereview.chromium.org/2662293002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
(left):

https://codereview.chromium.org/2662293002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java:42:
{
replaced this by Arrays.asList because that's an initialisation block that runs
for every SuggestionsSection instantiation. So not what we want, even though
because it's a set it didn't cause bugs.

[Bernhard Bauer, 2017-01-31 17:21:26]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2017-01-31 17:21:27]

lgtm

https://codereview.chromium.org/2662293002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
(left):

https://codereview.chromium.org/2662293002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java:42:
{
On 2017/01/31 17:17:55, dgn wrote:
> replaced this by Arrays.asList because that's an initialisation block that
runs
> for every SuggestionsSection instantiation. So not what we want, even though
> because it's a set it didn't cause bugs.

Oh, duh. I guess I should have made it a static initialization block, but this
works as well.

[dgn, 2017-01-31 18:21:58]

The CQ bit was unchecked by dgn@chromium.org

[dgn, 2017-01-31 18:21:59]

The CQ bit was checked by dgn@chromium.org

[dgn, 2017-01-31 18:22:08]

thanks!

[commit-bot: I haz the power, 2017-01-31 18:22:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 18:31:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485886919372390, "parent_rev":
"8185d9772224f42c18c942e8932441fe3ec025d7", "commit_rev":
"3ea8c007ce51f08fcc6429be7957e3d75627d8e9"}

[commit-bot: I haz the power, 2017-01-31 18:32:01]

Description was changed from

==========
[NTP Client] Handle optional item in group dismissal

Makes the suggestion section properly dismiss a single item
when the it does not show an action item.

BUG=687092
==========

to

==========
[NTP Client] Handle optional item in group dismissal

Makes the suggestion section properly dismiss a single item
when the it does not show an action item.

BUG=687092

Review-Url: https://codereview.chromium.org/2662293002
Cr-Commit-Position: refs/heads/master@{#447276}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ea8c007ce51f08fcc6429be7957...
==========

[commit-bot: I haz the power, 2017-01-31 18:32:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ea8c007ce51f08fcc6429be7957...