Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2662263003: Merged: Fix --noopt to not optimize (Closed)

Created:
3 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: Fix --noopt to not optimize Revision: 1fc5ca85fcc5bb75bd9b27eaf434f03cb5bf61fc BUG=chromium:639217, v8:5904 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2662263003 . Cr-Commit-Position: refs/branch-heads/5.7@{#78} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/3f95e1f85b1d5196a3fe77283bd785c61058f57e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M src/compilation-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/noopt.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jochen (gone - plz use gerrit)
3 years, 10 months ago (2017-01-31 19:50:23 UTC) #1
jochen (gone - plz use gerrit)
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-01-31 19:50:24 UTC) #2
jochen (gone - plz use gerrit)
Committed patchset #1 (id:1) manually as 3f95e1f85b1d5196a3fe77283bd785c61058f57e.
3 years, 10 months ago (2017-01-31 19:50:55 UTC) #4
Michael Starzinger
3 years, 10 months ago (2017-02-01 08:45:17 UTC) #5
Message was sent while issue was closed.
LGTM (rubber-stamped).

Powered by Google App Engine
This is Rietveld 408576698