Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2662263002: [turbo] Rename CallConstruct* operators to Construct*. (Closed)

Created:
3 years, 10 months ago by petermarshall
Modified:
3 years, 10 months ago
CC:
rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbo] Rename CallConstruct* operators to Construct*. Review-Url: https://codereview.chromium.org/2662263002 Cr-Commit-Position: refs/heads/master@{#42836} Committed: https://chromium.googlesource.com/v8/v8/+/1a1a3cc492a62e37dfcd5acbfb1b03f3d7db8075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -153 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-call-reducer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 6 chunks +16 lines, -17 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M src/compiler/js-inlining.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-operator.h View 5 chunks +23 lines, -24 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +33 lines, -38 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +10 lines, -12 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 4 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
petermarshall
WDYT - possible to land anytime soon?
3 years, 10 months ago (2017-01-31 15:03:43 UTC) #4
Benedikt Meurer
I like it a lot, removes the "Call" confusion and unifies naming with the actual ...
3 years, 10 months ago (2017-01-31 17:55:55 UTC) #9
Michael Starzinger
LGTM.
3 years, 10 months ago (2017-01-31 18:17:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662263002/1
3 years, 10 months ago (2017-02-01 08:10:09 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 08:11:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1a1a3cc492a62e37dfcd5acbfb1b03f3d7d...

Powered by Google App Engine
This is Rietveld 408576698