Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: trunk/src/ash/wm/maximize_mode/maximize_mode_event_blocker.cc

Issue 266223003: Revert 268181 "Enabled volume buttons when TouchView is active" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ash/wm/maximize_mode/maximize_mode_event_blocker.cc
===================================================================
--- trunk/src/ash/wm/maximize_mode/maximize_mode_event_blocker.cc (revision 268197)
+++ trunk/src/ash/wm/maximize_mode/maximize_mode_event_blocker.cc (working copy)
@@ -8,7 +8,6 @@
#include "base/memory/scoped_ptr.h"
#include "ui/aura/client/cursor_client.h"
#include "ui/events/event_targeter.h"
-#include "ui/events/keycodes/keyboard_codes.h"
namespace ash {
@@ -55,19 +54,8 @@
ui::EventTarget* BlockKeyboardAndTouchpadTargeter::FindTargetForEvent(
ui::EventTarget* root,
ui::Event* event) {
- if (event->HasNativeEvent()) {
- if (event->IsMouseEvent())
- return NULL;
- if (event->IsKeyEvent()) {
- // TODO(bruthig): Fix this to block rewritten volume keys
- // (i.e. F9 and F10) from the device's keyboard. https://crbug.com/368669
- ui::KeyEvent* key_event = static_cast<ui::KeyEvent*>(event);
- if (key_event->key_code() != ui::VKEY_VOLUME_DOWN &&
- key_event->key_code() != ui::VKEY_VOLUME_UP) {
- return NULL;
- }
- }
- }
+ if (event->HasNativeEvent() && (event->IsMouseEvent() || event->IsKeyEvent()))
+ return NULL;
return default_targeter_->FindTargetForEvent(root, event);
}
« no previous file with comments | « trunk/src/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698