Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: trunk/src/ash/wm/maximize_mode/maximize_mode_event_blocker.cc

Issue 266223003: Revert 268181 "Enabled volume buttons when TouchView is active" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « trunk/src/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/wm/maximize_mode/maximize_mode_event_blocker.h" 5 #include "ash/wm/maximize_mode/maximize_mode_event_blocker.h"
6 6
7 #include "ash/shell.h" 7 #include "ash/shell.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "ui/aura/client/cursor_client.h" 9 #include "ui/aura/client/cursor_client.h"
10 #include "ui/events/event_targeter.h" 10 #include "ui/events/event_targeter.h"
11 #include "ui/events/keycodes/keyboard_codes.h"
12 11
13 namespace ash { 12 namespace ash {
14 13
15 namespace { 14 namespace {
16 15
17 // Event targeter to prevent delivery of mouse and touchpad events while 16 // Event targeter to prevent delivery of mouse and touchpad events while
18 // maximize mode is active. Other events such as touch are passed on to the 17 // maximize mode is active. Other events such as touch are passed on to the
19 // default targeter. 18 // default targeter.
20 // TODO(flackr): This should only stop events from the internal keyboard and 19 // TODO(flackr): This should only stop events from the internal keyboard and
21 // touchpad. 20 // touchpad.
(...skipping 26 matching lines...) Expand all
48 } 47 }
49 48
50 void BlockKeyboardAndTouchpadTargeter::SetDefaultTargeter( 49 void BlockKeyboardAndTouchpadTargeter::SetDefaultTargeter(
51 ui::EventTargeter* default_targeter) { 50 ui::EventTargeter* default_targeter) {
52 default_targeter_ = default_targeter; 51 default_targeter_ = default_targeter;
53 } 52 }
54 53
55 ui::EventTarget* BlockKeyboardAndTouchpadTargeter::FindTargetForEvent( 54 ui::EventTarget* BlockKeyboardAndTouchpadTargeter::FindTargetForEvent(
56 ui::EventTarget* root, 55 ui::EventTarget* root,
57 ui::Event* event) { 56 ui::Event* event) {
58 if (event->HasNativeEvent()) { 57 if (event->HasNativeEvent() && (event->IsMouseEvent() || event->IsKeyEvent()))
59 if (event->IsMouseEvent()) 58 return NULL;
60 return NULL;
61 if (event->IsKeyEvent()) {
62 // TODO(bruthig): Fix this to block rewritten volume keys
63 // (i.e. F9 and F10) from the device's keyboard. https://crbug.com/368669
64 ui::KeyEvent* key_event = static_cast<ui::KeyEvent*>(event);
65 if (key_event->key_code() != ui::VKEY_VOLUME_DOWN &&
66 key_event->key_code() != ui::VKEY_VOLUME_UP) {
67 return NULL;
68 }
69 }
70 }
71 return default_targeter_->FindTargetForEvent(root, event); 59 return default_targeter_->FindTargetForEvent(root, event);
72 } 60 }
73 61
74 } // namespace 62 } // namespace
75 63
76 MaximizeModeEventBlocker::MaximizeModeEventBlocker() { 64 MaximizeModeEventBlocker::MaximizeModeEventBlocker() {
77 Shell::GetInstance()->AddShellObserver(this); 65 Shell::GetInstance()->AddShellObserver(this);
78 66
79 // Hide the cursor as mouse events will be blocked. 67 // Hide the cursor as mouse events will be blocked.
80 aura::client::CursorClient* cursor_client_ = 68 aura::client::CursorClient* cursor_client_ =
(...skipping 22 matching lines...) Expand all
103 aura::Window* root_window) { 91 aura::Window* root_window) {
104 BlockKeyboardAndTouchpadTargeter* targeter = 92 BlockKeyboardAndTouchpadTargeter* targeter =
105 new BlockKeyboardAndTouchpadTargeter(); 93 new BlockKeyboardAndTouchpadTargeter();
106 aura::ScopedWindowTargeter* scoped_targeter = new aura::ScopedWindowTargeter( 94 aura::ScopedWindowTargeter* scoped_targeter = new aura::ScopedWindowTargeter(
107 root_window, scoped_ptr<ui::EventTargeter>(targeter)); 95 root_window, scoped_ptr<ui::EventTargeter>(targeter));
108 targeter->SetDefaultTargeter(scoped_targeter->old_targeter()); 96 targeter->SetDefaultTargeter(scoped_targeter->old_targeter());
109 targeters_.push_back(scoped_targeter); 97 targeters_.push_back(scoped_targeter);
110 } 98 }
111 99
112 } // namespace ash 100 } // namespace ash
OLDNEW
« no previous file with comments | « trunk/src/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698