Issue 266223003: Revert 268181 "Enabled volume buttons when TouchView is active"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266223003: Revert 268181 "Enabled volume buttons when TouchView is active" (Closed)

Created:
6 years, 7 months ago by Albert Bodenhamer

Modified:
6 years, 7 months ago

Reviewers:
bruthig

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 268181 "Enabled volume buttons when TouchView is active" > Enabled volume buttons when TouchView is active > > BUG=364584 > TEST=MaximizeModeControllerTest.AllowsVolumeControl > > Review URL: https://codereview.chromium.org/251193005 TBR=bruthig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268198

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -152 lines)			Patch
M	trunk/src/ash/accelerators/accelerator_controller_unittest.cc	View	7 chunks	+55 lines, -8 lines	0 comments	Download
M	trunk/src/ash/ash.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	trunk/src/ash/test/test_volume_control_delegate.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	trunk/src/ash/test/test_volume_control_delegate.cc	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	trunk/src/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc	View	4 chunks	+2 lines, -32 lines	0 comments	Download
M	trunk/src/ash/wm/maximize_mode/maximize_mode_event_blocker.cc	View	2 chunks	+2 lines, -14 lines	0 comments	Download

Total messages: 2 (0 generated)

Albert Bodenhamer

6 years, 7 months ago (2014-05-05 16:44:25 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r268198 (tree was closed).