Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2662213006: Reject requestPresent requests when fullscreen is not enabled. (Closed)

Created:
3 years, 10 months ago by mthiesse
Modified:
3 years, 10 months ago
Reviewers:
bajones
CC:
chromium-reviews, blink-reviews, haraken, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject requestPresent requests when fullscreen is not enabled. BUG=687369 Review-Url: https://codereview.chromium.org/2662213006 Cr-Commit-Position: refs/heads/master@{#447540} Committed: https://chromium.googlesource.com/chromium/src/+/b29ec7143c6fbc8ea4271c7f5e3428dae0c4eba8

Patch Set 1 #

Patch Set 2 : rebase + address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 1 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mthiesse
PTAL
3 years, 10 months ago (2017-02-01 01:13:46 UTC) #2
bajones
Can you add a comment about removing the fullscreen restriction to VRDisplay.cpp. Then it LGTM.
3 years, 10 months ago (2017-02-01 05:00:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662213006/20001
3 years, 10 months ago (2017-02-01 15:07:20 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 17:02:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b29ec7143c6fbc8ea4271c7f5e34...

Powered by Google App Engine
This is Rietveld 408576698