Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2662183006: DevTools: Don't clip tirangles in ObjectPropertiesSection (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
dgozman, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't clip tirangles in ObjectPropertiesSection The treeoutline icons are in a new sprite sheet, but the OPS was using the old offsets. BUG=687503 Review-Url: https://codereview.chromium.org/2662183006 Cr-Commit-Position: refs/heads/master@{#447671} Committed: https://chromium.googlesource.com/chromium/src/+/d94283714ede2293aa93e7d4a1d90115c4dbb60f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/objectPropertiesSection.css View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
einbinder
ptal @dogzman an old patch by you used 97px instead of the normal 96px for ...
3 years, 10 months ago (2017-02-01 21:49:08 UTC) #2
dgozman
lgtm
3 years, 10 months ago (2017-02-01 23:28:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662183006/1
3 years, 10 months ago (2017-02-01 23:32:22 UTC) #5
lushnikov
Thanks, LGTM! I've attributed the CL with the bug. For the record: this was regressed ...
3 years, 10 months ago (2017-02-01 23:41:02 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 01:23:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d94283714ede2293aa93e7d4a1d9...

Powered by Google App Engine
This is Rietveld 408576698