Chromium Code Reviews
DescriptionRevert of scheduler: Detect single event gestures correctly (patchset #3 id:40001 of https://codereview.chromium.org/2663283002/ )
Reason for revert:
Caused a test build break.
Original issue's description:
> scheduler: Detect single event gestures correctly
>
> When a single event gesture such as a press (i.e., a single touchstart
> event) is observed, the scheduler would previously wait for two
> subsequent touchmove events before deciding the gesture was established
> and stop blocking tasks unrelated to input handling. The problem was
> that with single event gestures, these additional events are never sent,
> so the scheduler would remain in 'touchstart' mode for 100ms, possibly
> causing important tasks to get delayed.
>
> This patch fixes the issue by telling the scheduler how the touchstart
> event was handled. If the event handler calls preventDefault() on the
> event, the scheduler can immediately conclude that the gesture is
> handled by the main thread without waiting for any further events. If
> preventDefault() is not called, we maintain the previous behavior.
>
> BUG=639300
> TBR=dtapuska@chromium.org
>
> Review-Url: https://codereview.chromium.org/2661443003
> Cr-Commit-Position: refs/heads/master@{#446921}
> (cherry picked from commit cff6288fd965f274205ca6ab9cded462ba204dc9)
>
> Review-Url: https://codereview.chromium.org/2663283002 .
> Cr-Commit-Position: refs/branch-heads/2987@{#230}
> Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
> Committed: https://chromium.googlesource.com/chromium/src/+/6db2c563baa4b5d4dbd4bbb052db0003ea5a0f1e
TBR=dtapuska@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=639300
Review-Url: https://codereview.chromium.org/2662173005
Cr-Commit-Position: refs/branch-heads/2987@{#233}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/dae9cdcdccded3723dbcf1d8a0d4d7b05a91b3ca
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|