Kill the app when render process is killed

Kill the app when render process is killed

For backward compatible, kill the app when render process was killed
and the event wasn't handled by app.

BUG=686199
Review-Url: https://codereview.chromium.org/2662143002
Cr-Commit-Position: refs/heads/master@{#447270}
Committed: https://chromium.googlesource.com/chromium/src/+/2f8b35e8d507ba8999d0fcc642b7ecadb1c2c6d8

[michaelbai, 2017-01-31 01:26:50]

Description was changed from

==========
Kill the app when render process is killed

For backward compatible, kill the app when render process was killed
and the event wasn't handled by app.

BUG=686199
==========

to

==========
Kill the app when render process is killed

For backward compatible, kill the app when render process was killed
and the event wasn't handled by app.

BUG=686199
==========

[michaelbai, 2017-01-31 01:26:51]

michaelbai@chromium.org changed reviewers:
+ sgurun@chromium.org, torne@chromium.org

[Torne, 2017-01-31 11:56:41]

Change the message a bit, but logic LGTM.

https://codereview.chromium.org/2662143002/diff/1/android_webview/browser/aw_...
File android_webview/browser/aw_browser_terminator.cc (right):

https://codereview.chromium.org/2662143002/diff/1/android_webview/browser/aw_...
android_webview/browser/aw_browser_terminator.cc:78: LOG(ERROR) << "The event of
render process has been killed wasn't"
not very clear wording; how about "Render process kill (OOM or update) wasn't
handed by all associated webviews, killing application." ?

[michaelbai, 2017-01-31 17:46:21]

https://codereview.chromium.org/2662143002/diff/1/android_webview/browser/aw_...
File android_webview/browser/aw_browser_terminator.cc (right):

https://codereview.chromium.org/2662143002/diff/1/android_webview/browser/aw_...
android_webview/browser/aw_browser_terminator.cc:78: LOG(ERROR) << "The event of
render process has been killed wasn't"
On 2017/01/31 11:56:41, Torne wrote:
> not very clear wording; how about "Render process kill (OOM or update) wasn't
> handed by all associated webviews, killing application." ?

Done.

[michaelbai, 2017-01-31 17:46:29]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2017-01-31 17:46:32]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2662143002/#ps20001
(title: "change log")

[commit-bot: I haz the power, 2017-01-31 17:47:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 18:15:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485884789659160,
"parent_rev": "c39590d5eb4e5fb4f99749916748bc468d689933", "commit_rev":
"2f8b35e8d507ba8999d0fcc642b7ecadb1c2c6d8"}

[commit-bot: I haz the power, 2017-01-31 18:16:43]

Description was changed from

==========
Kill the app when render process is killed

For backward compatible, kill the app when render process was killed
and the event wasn't handled by app.

BUG=686199
==========

to

==========
Kill the app when render process is killed

For backward compatible, kill the app when render process was killed
and the event wasn't handled by app.

BUG=686199

Review-Url: https://codereview.chromium.org/2662143002
Cr-Commit-Position: refs/heads/master@{#447270}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f8b35e8d507ba8999d0fcc642b7...
==========

[commit-bot: I haz the power, 2017-01-31 18:16:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f8b35e8d507ba8999d0fcc642b7...