[ic] Introduce IsXyzIC() predicates.

[ic] Introduce IsXyzIC() predicates.

This is a step towards encoding all the necessary information in
the feedback slot kind instead of storing it in the IC dispatcher's
code object flags.

BUG=v8:5849, v8:5917
Review-Url: https://codereview.chromium.org/2662113005
Cr-Commit-Position: refs/heads/master@{#42859}
Committed: https://chromium.googlesource.com/v8/v8/+/93f181b6b9bfd0f48c4e8a8fc13ad6e662b6faa6

[Igor Sheludko, 2017-02-01 14:15:48]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2017-02-01 14:16:53]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 14:17:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-02-01 14:19:19]

ishell@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Igor Sheludko, 2017-02-01 14:19:19]

PTAL

[Igor Sheludko, 2017-02-01 14:20:21]

Description was changed from

==========
[ic] Introduce IsXXXIC() predicates.

This is a step towards encoding all the necessary information in
the feedback slot kind instead of storing it in the IC dispatcher's
code object flags.

BUG=v8:5849, v8:5917
==========

to

==========
[ic] Introduce IsXyzIC() predicates.

This is a step towards encoding all the necessary information in
the feedback slot kind instead of storing it in the IC dispatcher's
code object flags.

BUG=v8:5849, v8:5917
==========

[commit-bot: I haz the power, 2017-02-01 14:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 14:47:42]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-02-01 15:57:13]

LGTM.

Just one nit. Thanks!

https://codereview.chromium.org/2662113005/diff/20001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (left):

https://codereview.chromium.org/2662113005/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.cc:200: for (int i = 0; i < slot_count;) {
Actually if you can keep this here I'd prefer it, even though it doesn't (right
now) allocate.
My vector CL in the next couple of days addresses this todo with a neat
insertion of an allocation here.

[Igor Sheludko, 2017-02-01 16:10:01]

Landing...

https://codereview.chromium.org/2662113005/diff/20001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (left):

https://codereview.chromium.org/2662113005/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.cc:200: for (int i = 0; i < slot_count;) {
On 2017/02/01 15:57:12, mvstanton wrote:
> Actually if you can keep this here I'd prefer it, even though it doesn't
(right
> now) allocate.
> My vector CL in the next couple of days addresses this todo with a neat
> insertion of an allocation here.

As discussed offline, we should better remove the no_gc scope below (with proper
handlification) and have only one initializing pass even when we start
allocating.

[Igor Sheludko, 2017-02-01 16:10:16]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-02-01 16:10:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 16:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 16:13:56]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33832)

[Jarin, 2017-02-01 16:16:47]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2017-02-01 16:16:48]

lgtm for compiler/* and crankshaft/*.

[Igor Sheludko, 2017-02-01 16:19:59]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-02-01 16:20:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 16:22:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485965999426440,
"parent_rev": "c00aeb030086024c380ed7013b1480a4c5d33cfc", "commit_rev":
"93f181b6b9bfd0f48c4e8a8fc13ad6e662b6faa6"}

[commit-bot: I haz the power, 2017-02-01 16:22:10]

Description was changed from

==========
[ic] Introduce IsXyzIC() predicates.

This is a step towards encoding all the necessary information in
the feedback slot kind instead of storing it in the IC dispatcher's
code object flags.

BUG=v8:5849, v8:5917
==========

to

==========
[ic] Introduce IsXyzIC() predicates.

This is a step towards encoding all the necessary information in
the feedback slot kind instead of storing it in the IC dispatcher's
code object flags.

BUG=v8:5849, v8:5917

Review-Url: https://codereview.chromium.org/2662113005
Cr-Commit-Position: refs/heads/master@{#42859}
Committed:
https://chromium.googlesource.com/v8/v8/+/93f181b6b9bfd0f48c4e8a8fc13ad6e662b...
==========

[commit-bot: I haz the power, 2017-02-01 16:22:11]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/93f181b6b9bfd0f48c4e8a8fc13ad6e662b...