Issue 2662093004: [turbofan] Mark loads of a module (from a module context) immutable.

Issue 2662093004: [turbofan] Mark loads of a module (from a module context) immutable. (Closed)

Created:
3 years, 10 months ago by neis

Modified:
3 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-reviews_googlegroups.com, rmcilroy

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Mark loads of a module (from a module context) immutable. This is sound because the slot never changes, and it enables optimization by JSContextSpecialization. R=mstarzinger@chromium.org BUG= Review-Url: https://codereview.chromium.org/2662093004 Cr-Commit-Position: refs/heads/master@{#42848} Committed: https://chromium.googlesource.com/v8/v8/+/68a8cb532edc3c8b53aa6eb717f2b44a7feb3147

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
	M	src/compiler/bytecode-graph-builder.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	A	test/mjsunit/modules-turbo2.js	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662093004/1

3 years, 10 months ago (2017-02-01 10:25:38 UTC) #4

commit-bot: I haz the power

3 years, 10 months ago (2017-02-01 10:51:28 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/68a8cb532edc3c8b53aa6eb717f2b44a7fe...