|
|
Chromium Code Reviews
DescriptionUpdate the descriptions of new permission string for search geolocation
The desc string for the blocked string was the same as the desc string
for the allowed string. Also the descriptions were slightly out of date and reflected the older strings.
BUG=674398
Review-Url: https://codereview.chromium.org/2662093003
Cr-Commit-Position: refs/heads/master@{#447625}
Committed: https://chromium.googlesource.com/chromium/src/+/64dcf43897c11b5ddbfd849fe1145a74fe0b0b89
Patch Set 1 #Patch Set 2 : Fix other bits #Messages
Total messages: 20 (12 generated)
The CQ bit was checked by benwells@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Update incorrect description of permission string for search geolocation The desc string for the blocked string was the same as the desc string for the allowed string. BUG=674398 ========== to ========== Update the descriptions of new permission string for search geolocation The desc string for the blocked string was the same as the desc string for the allowed string. Also the descriptions were slightly out of date and reflected the older strings. BUG=674398 ==========
benwells@chromium.org changed reviewers: + raymes@chromium.org
lgtm
The CQ bit was checked by benwells@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
benwells@chromium.org changed reviewers: + dfalcantara@chromium.org
Oh, this file needs an OWNER. dfalcantara, how's the load? This should be a quick one...
lgtm
The CQ bit was checked by benwells@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485988618471920,
"parent_rev": "a0bad9614963ebd5871dc828a9da0b3ae078c750", "commit_rev":
"64dcf43897c11b5ddbfd849fe1145a74fe0b0b89"}
Message was sent while issue was closed.
Description was changed from ========== Update the descriptions of new permission string for search geolocation The desc string for the blocked string was the same as the desc string for the allowed string. Also the descriptions were slightly out of date and reflected the older strings. BUG=674398 ========== to ========== Update the descriptions of new permission string for search geolocation The desc string for the blocked string was the same as the desc string for the allowed string. Also the descriptions were slightly out of date and reflected the older strings. BUG=674398 Review-Url: https://codereview.chromium.org/2662093003 Cr-Commit-Position: refs/heads/master@{#447625} Committed: https://chromium.googlesource.com/chromium/src/+/64dcf43897c11b5ddbfd849fe114... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/64dcf43897c11b5ddbfd849fe114... |
