Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2662093003: Update incorrect description of permission string for search geolocation (Closed)

Created:
3 years, 10 months ago by benwells
Modified:
3 years, 10 months ago
Reviewers:
raymes, gone
CC:
chromium-reviews, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the descriptions of new permission string for search geolocation The desc string for the blocked string was the same as the desc string for the allowed string. Also the descriptions were slightly out of date and reflected the older strings. BUG=674398 Review-Url: https://codereview.chromium.org/2662093003 Cr-Commit-Position: refs/heads/master@{#447625} Committed: https://chromium.googlesource.com/chromium/src/+/64dcf43897c11b5ddbfd849fe1145a74fe0b0b89

Patch Set 1 #

Patch Set 2 : Fix other bits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
benwells
3 years, 10 months ago (2017-01-31 22:28:05 UTC) #7
raymes
lgtm
3 years, 10 months ago (2017-02-01 18:06:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662093003/20001
3 years, 10 months ago (2017-02-01 19:26:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/354905)
3 years, 10 months ago (2017-02-01 19:34:50 UTC) #12
benwells
Oh, this file needs an OWNER. dfalcantara, how's the load? This should be a quick ...
3 years, 10 months ago (2017-02-01 21:17:24 UTC) #14
gone
lgtm
3 years, 10 months ago (2017-02-01 21:20:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662093003/20001
3 years, 10 months ago (2017-02-01 22:37:20 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 22:47:35 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/64dcf43897c11b5ddbfd849fe114...

Powered by Google App Engine
This is Rietveld 408576698