Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2661983002: Add 20 resources for options_resources.grd. (Closed)

Created:
3 years, 10 months ago by sammiequon
Modified:
3 years, 10 months ago
Reviewers:
flackr
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 20 resources for options_resources.grd. Cannot add new structures to options_resources.grd at the moment due to there being allocated 30 resources and options_resources.grd already has 30 resources. BUG=686833 TEST=none Review-Url: https://codereview.chromium.org/2661983002 Cr-Commit-Position: refs/heads/master@{#447134} Committed: https://chromium.googlesource.com/chromium/src/+/d523103ef65af1e0cc514af41e2e26e2747e5f97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M tools/gritsettings/resource_ids View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sammiequon
On 2017/01/30 19:27:03, sammiequon wrote: > mailto:sammiequon@chromium.org changed reviewers: > + mailto:flackr@chromium.org flackr@ - Please ...
3 years, 10 months ago (2017-01-30 19:27:53 UTC) #3
flackr
lgtm
3 years, 10 months ago (2017-01-30 23:25:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661983002/1
3 years, 10 months ago (2017-01-30 23:27:28 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 00:38:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d523103ef65af1e0cc514af41e2e...

Powered by Google App Engine
This is Rietveld 408576698