DevTools: extract treeoutline triangle icons from toolbarButtonGlyphs.png

DevTools: extract treeoutline triangle icons from toolbarButtonGlyphs.png

This patch extracts treeoutline triangle icons from toolbarButtonGlyphs.png.
These are hard to migrate to the UI.Icon and they never change, so this
is a legit compromise.

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2661893002
Cr-Commit-Position: refs/heads/master@{#447217}
Committed: https://chromium.googlesource.com/chromium/src/+/c92fc23928f524266a2bb85acc086148d51550ac

[lushnikov, 2017-01-30 14:53:16]

Please, take a look

[lushnikov, 2017-01-30 14:54:05]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 14:54:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 14:55:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 14:55:58]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[pfeldman, 2017-01-30 18:51:02]

Description was changed from

==========
DevTools: extract treeoutline triangle icons from toolbarButtonGlyphs.png

This patch extracts treeoutline triangle icons from toolbarButtonGlyphs.png.
These are hard to migrate to the UI.Icon and they never change, so this
is a legit compromise.

BUG=669323
R=dgozman
==========

to

==========
DevTools: extract treeoutline triangle icons from toolbarButtonGlyphs.png

This patch extracts treeoutline triangle icons from toolbarButtonGlyphs.png.
These are hard to migrate to the UI.Icon and they never change, so this
is a legit compromise.

BUG=669323
R=dgozman
==========

[pfeldman, 2017-01-30 18:51:02]

pfeldman@chromium.org changed reviewers:
+ einbinder@chromium.org

[dgozman, 2017-01-30 19:31:21]

lgtm

https://codereview.chromium.org/2661893002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.css (left):

https://codereview.chromium.org/2661893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.css:127:
-webkit-mask-position: -4px -96px;
I remember some of them were positioned one-pixel-off to align better. Could you
please search for all +1/-1 combinations as well?

[lushnikov, 2017-01-31 09:12:42]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-01-31 09:12:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2661893002/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-01-31 09:12:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-01-31 09:14:29]

https://codereview.chromium.org/2661893002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.css (left):

https://codereview.chromium.org/2661893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.css:127:
-webkit-mask-position: -4px -96px;
On 2017/01/30 19:31:21, dgozman_slow wrote:
> I remember some of them were positioned one-pixel-off to align better. Could
you
> please search for all +1/-1 combinations as well?

Looks like those were moved over to UI.Icon. We have only a handful of
toolbarButtonGlyphs.png references in the codebase - i've checked them all

[commit-bot: I haz the power, 2017-01-31 11:52:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485853962800820,
"parent_rev": "3b39bb8d4942bbf79cbd36f24ae8a861e3f78fa4", "commit_rev":
"c92fc23928f524266a2bb85acc086148d51550ac"}

[commit-bot: I haz the power, 2017-01-31 11:52:43]

Description was changed from

==========
DevTools: extract treeoutline triangle icons from toolbarButtonGlyphs.png

This patch extracts treeoutline triangle icons from toolbarButtonGlyphs.png.
These are hard to migrate to the UI.Icon and they never change, so this
is a legit compromise.

BUG=669323
R=dgozman
==========

to

==========
DevTools: extract treeoutline triangle icons from toolbarButtonGlyphs.png

This patch extracts treeoutline triangle icons from toolbarButtonGlyphs.png.
These are hard to migrate to the UI.Icon and they never change, so this
is a legit compromise.

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2661893002
Cr-Commit-Position: refs/heads/master@{#447217}
Committed:
https://chromium.googlesource.com/chromium/src/+/c92fc23928f524266a2bb85acc08...
==========

[commit-bot: I haz the power, 2017-01-31 11:52:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c92fc23928f524266a2bb85acc08...