Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2661773002: [wasm] Update table bounds when module is instantiated with a table import (Closed)

Created:
3 years, 10 months ago by gdeepti
Modified:
3 years, 10 months ago
Reviewers:
titzer, bradnelson, bradn
CC:
v8-reviews_googlegroups.com, Derek Schuff
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Update table bounds when module is instantiated with a table import When WebAssembly.Table initial size is greater than the declared initial size, table size references should be updated on instantiate for functions to be called at indices greater than the declared initial size. R=bradnelson@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2661773002 Cr-Commit-Position: refs/heads/master@{#42781} Committed: https://chromium.googlesource.com/v8/v8/+/930142e8773e25ee1c3ef29f14a3c1fdb189bd27

Patch Set 1 #

Patch Set 2 : [wasm] Fix bounds check for imported size > declared initial size of table #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M src/wasm/wasm-module.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/indirect-tables.js View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
gdeepti
3 years, 10 months ago (2017-01-28 04:33:56 UTC) #5
bradn
lgtm
3 years, 10 months ago (2017-01-28 05:11:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661773002/20001
3 years, 10 months ago (2017-01-28 17:43:56 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33577)
3 years, 10 months ago (2017-01-28 17:47:07 UTC) #16
bradnelson
lgtm
3 years, 10 months ago (2017-01-30 17:36:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661773002/20001
3 years, 10 months ago (2017-01-30 17:36:11 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 18:10:39 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/930142e8773e25ee1c3ef29f14a3c1fdb18...

Powered by Google App Engine
This is Rietveld 408576698