extensions/renderer/extension_frame_helper.h - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/extension_frame_helper.h

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/extension_frame_helper.h

diff --git a/extensions/renderer/extension_frame_helper.h b/extensions/renderer/extension_frame_helper.h

index f45129e19c2e590f1ecb9d6e88167d1e69b79412..ee91a76d4c20ceea8023d31fe9474fd275270221 100644

--- a/extensions/renderer/extension_frame_helper.h

+++ b/extensions/renderer/extension_frame_helper.h

@@ -90,7 +90,7 @@ class ExtensionFrameHelper

const blink::WebVector<blink::WebString>& newly_matching_selectors,

const blink::WebVector<blink::WebString>& stopped_matching_selectors)

override;

- void DidStartProvisionalLoad() override;

+ void DidStartProvisionalLoad(blink::WebDataSource* data_source) override;

void DidCreateScriptContext(v8::Local<v8::Context>,

int world_id) override;

void WillReleaseScriptContext(v8::Local<v8::Context>, int world_id) override;

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | extensions/renderer/extension_frame_helper.cc » ('j') | no next file with comments »